feat: add java output for codegen initial version - #62
Closed
anghelflorinm wants to merge 44 commits into
Closed
Conversation
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <44744433+anghelflorinm@users.noreply.github.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
…t schema Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
format #2 Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florin-Mihai Anghel <44744433+anghelflorinm@users.noreply.github.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
…emory files Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
…egen into 2-cli-prototype
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florin-Mihai Anghel <44744433+anghelflorinm@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Florin-Mihai Anghel <44744433+anghelflorinm@users.noreply.github.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
…egen into 2-cli-prototype
…egen into 2-cli-prototype
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
…egen into 2-cli-prototype
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.9](v0.1.8...v0.1.9) (2024-11-27) ### 🧹 Chore * remove empty testutils package ([#55](#55)) ([9dc1d9f](9dc1d9f)) * update back to previous mkdir permissions ([#61](#61)) ([515b534](515b534)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
…into java-output
Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.9](v0.1.8...v0.1.9) (2024-11-27) ### 🧹 Chore * remove empty testutils package ([#55](#55)) ([9dc1d9f](9dc1d9f)) * update back to previous mkdir permissions ([#61](#61)) ([515b534](515b534)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
…into java-output
This reverts commit 2753953. Signed-off-by: Florin-Mihai Anghel <fanghel@google.com>
kriscoleman
reviewed
Mar 4, 2025
| case types.StringType: | ||
| return "String" | ||
| default: | ||
| return "" |
Collaborator
There was a problem hiding this comment.
does types.ObjectType case belong here too?
EDIT: Michael let me know that this is OOS for now, so disregard 😄
Collaborator
|
To better understand the project, I took the opportunity to get hands-on with this PR. I built this branch and ran 
Everything worked smoothly! I do have a couple of follow-up questions:
Looking forward to your insights! |
Member
Yeah, we're omitting objects for now. I'll cut a follow up issue to work on it later but it adds a lot of complexity.
I'm in favor of adding support for Kotlin. However, please wait until my pending PR is merged. We'll likely be refactoring the generator logic fairly significantly. |
Collaborator
I think the idea to codegen dynamically structured flags is really neat. I can understand how it could quickly spiral into complexity though 😅 thanks for answering my questions! |
Member
|
I'll close this since the generator structure has changed significantly. I've created an issue to add a Java generator based on the new format. FYI @kriscoleman |
jonathannorris
added a commit
that referenced
this pull request
Aug 4, 2026
- postcss <= 8.5.17 -> ^8.5.18 override (high, alert #62) - pin fast-uri override to exact 3.1.4 per CodeRabbit review suggestion Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
jonathannorris
added a commit
that referenced
this pull request
Aug 17, 2026
* chore: resolve open dependabot security alerts - vite ^6.4.2 -> ^6.4.3 (medium/high, alerts #57 #58) - @babel/core transitive -> ^7.29.6 via override (low, alert #56) - @angular/common, @angular/core, @angular/compiler 19.x -> 20.3.25 (high/medium, alerts #52 #53 #54 #55) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: align @openfeature/web-sdk with angular-sdk peer dependency Address Copilot review feedback on PR #253: @openfeature/angular-sdk 1.3.1 requires @openfeature/web-sdk ^1.9.0 as a peer dependency, but package.json still allowed ^1.7.3. Bump the declared range to match and regenerate the lockfile. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: resolve additional dependabot alerts for fast-uri - fast-uri ^3.1.2 -> ^3.1.4 (high, alert #59: host confusion via failed IDN canonicalization) - fast-uri ^3.1.2 -> ^3.1.4 (high, alert #60: host confusion via literal backslash authority delimiter) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * fix(deps): regenerate OpenAPI client for oapi-codegen v2.8.0 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: resolve postcss alert and pin fast-uri exactly - postcss <= 8.5.17 -> ^8.5.18 override (high, alert #62) - pin fast-uri override to exact 3.1.4 per CodeRabbit review suggestion Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump fast-uri to 3.1.5 for dependabot alert #64 - fast-uri 3.1.4 -> 3.1.5 (high, alert #64: host confusion via backslash authority introducer) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: resolve open dependabot security alerts - @angular/core 20.3.25 -> 20.3.28 (high, alert #75: XSS via event-handler attributes) - @angular/compiler 20.3.25 -> 20.3.28 (high, alert #74: XSS via event-handler attributes) - @angular/common 20.3.25 -> 20.3.28 (high, alert #73: cache-key ambiguity in HttpTransferCache) - brace-expansion 2.1.0 -> 2.1.4 (high, alert #72: DoS via exponential-time expansion) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> --------- Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
beeme1mr
pushed a commit
to joshhunt/cli
that referenced
this pull request
Aug 18, 2026
* chore: resolve open dependabot security alerts - vite ^6.4.2 -> ^6.4.3 (medium/high, alerts open-feature#57 open-feature#58) - @babel/core transitive -> ^7.29.6 via override (low, alert open-feature#56) - @angular/common, @angular/core, @angular/compiler 19.x -> 20.3.25 (high/medium, alerts open-feature#52 open-feature#53 open-feature#54 open-feature#55) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: align @openfeature/web-sdk with angular-sdk peer dependency Address Copilot review feedback on PR open-feature#253: @openfeature/angular-sdk 1.3.1 requires @openfeature/web-sdk ^1.9.0 as a peer dependency, but package.json still allowed ^1.7.3. Bump the declared range to match and regenerate the lockfile. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: resolve additional dependabot alerts for fast-uri - fast-uri ^3.1.2 -> ^3.1.4 (high, alert open-feature#59: host confusion via failed IDN canonicalization) - fast-uri ^3.1.2 -> ^3.1.4 (high, alert open-feature#60: host confusion via literal backslash authority delimiter) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * fix(deps): regenerate OpenAPI client for oapi-codegen v2.8.0 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: resolve postcss alert and pin fast-uri exactly - postcss <= 8.5.17 -> ^8.5.18 override (high, alert open-feature#62) - pin fast-uri override to exact 3.1.4 per CodeRabbit review suggestion Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> * chore: bump fast-uri to 3.1.5 for dependabot alert open-feature#64 - fast-uri 3.1.4 -> 3.1.5 (high, alert open-feature#64: host confusion via backslash authority introducer) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com> --------- Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR